Feature/mui 6 and pigment css #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
What is the current behavior?
The skeleton uses MUI v5
What is the new behavior?
The skeleton will use MUI v6 with Pigmet css.
Checklist
Please check that your PR fulfills the following requirements:
Other information
Pigment css is a zero runtine css-in-js library. Unlike emotion or styled components, the CSS is not compiled dynamically by the browser when loading components - it is fully compiled during the project's build step.
Steps to migrate from MUI 5 to 6 are documented here:
https://mui.com/material-ui/migration/migrating-to-pigment-css/
Important note: Dynamic styles (based on props, for example) no longer work. You will need to use css variables. A couple of examples (with before & after code snippets) can be found here:
https://mui.com/material-ui/migration/migrating-to-pigment-css/#migrating-dynamic-styles