New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/ch/add UI kit #7

Merged

ChuckLeon merged 23 commits into main from dev/ch/add-ui-kit

Aug 12, 2024

Contributor

ChuckLeon commented Jul 24, 2024 •

edited by MounirAbdousNventive

Loading

GitHub Issue or Internal Use Azure Devops Work Item ID:

Proposed Changes

Feature
Code style update (formatting)
Refactoring (no functional changes, no api changes)

What is the current behavior?

We do not have an uikit page where you can preview components
Loading component is only made to be fullscreen
Spinner animation changes the width and height wich is not good practice

What is the new behavior?

New page that allows you to see components in controlled environement
Loading component can be isolated or fullscreen
Spinner only spin whatever is inside of it without changing size
Changed the loader icon to be simpler to change for other projects

Checklist

Please check that your PR fulfills the following requirements:

Documentation has been added/updated.

Other information

ChuckLeon added the enhancement label

ChuckLeon requested review from luisdlopez, Seeila, KarmineSH and MounirAbdousNventive

July 24, 2024 17:37

ChuckLeon self-assigned this

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/App.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/App.tsx Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/components/layout/Layout.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/components/loading/Loading.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/components/loading/loading.scss Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/components/loading/loading.scss Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/components/spinner/Spinner.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/components/spinner/Spinner.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/components/spinner/Spinner.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/components/spinner/spinner.scss Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/containers/debugBanner/DebugBanner.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/containers/debugBanner/DebugBanner.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/containers/debugBanner/DebugBanner.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/containers/debugBanner/DebugBanner.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/styles/_variables.scss Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/pages/uikit/UiKit.tsx Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/pages/uikit/withAuthUikit.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/pages/uikit/uikit.route.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/containers/debugBanner/DebugBanner.tsx Outdated Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/containers/debugBanner/DebugBanner.tsx Show resolved Hide resolved

MounirAbdousNventive reviewed

View reviewed changes

frontend/src/app/components/loading/loading.scss Outdated Show resolved Hide resolved

ChuckLeon force-pushed the dev/ch/add-ui-kit branch from 110877d to 4663900 Compare

August 1, 2024 18:48

KarmineSH suggested changes

View reviewed changes

frontend/src/app/components/fieldHelperText/FieldHelperText.tsx Show resolved Hide resolved

frontend/src/app/components/spinner/spinner.scss Outdated Show resolved Hide resolved

frontend/src/app/components/uikitBlock/UikitBlock.tsx Outdated Show resolved Hide resolved

frontend/src/app/pages/uikit/UiKit.tsx Show resolved Hide resolved

ChuckLeon force-pushed the dev/ch/add-ui-kit branch from 90c5466 to d78e976 Compare

August 7, 2024 17:17

Charles Héon added 22 commits

August 7, 2024 14:07


          feat: adding uikit page

d826853


          fix: changes fieldHelperText

10ef2ec


          fix: changes spinner + creates uikitBlock

79052f7


          feat: adds fieldHelperText with errors to uikit + styling changes

70d4ee2


          fix: makes some tweaks to text

09a8da4


          fix: makes uikitblock simpler

5c04971


          fix: changes loading icon + small ui tweaks

a9ccdfc


          fix: adds uikit pages to i18n sheets

1fbe24e


          feat: adds property-without-direction for easy css class

c019d0e


          fix: switch back to pure css loader

fc99148


          fix: changes how we show debugbanner link buttons

b629926


          fix: switches codeblock package + changes property css generator


          fix: changes debugbanner place

c889c53


          fix: separated the spinner to be individual component

cbe6236


          fix: removes fullscreen references

b2ab2e0


          feat: adds typos and colors to uikit

d67ba2e


          fix: changes after pr comments

a341c91


          fix: adds back primary color in uikit + adds bg- color class

334e817


          fix: reverts spinner to original

637e0bd


          fix: changes spinner.tsx back to correct format

4e0cebb


          fix: switching to projects way to handle typographies

1d1f723


          feat: adding media-queries mixins

482090c

ChuckLeon force-pushed the dev/ch/add-ui-kit branch from dd000e0 to 482090c Compare

August 7, 2024 18:07


          feat: makes mixins more extendable

959475b

ChuckLeon requested a review from KarmineSH

August 12, 2024 14:28

KarmineSH approved these changes

View reviewed changes

ChuckLeon merged commit 3f8a577 into main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels