fix: prioritize user config for extensions on windows #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the second part of: nvim-lualine#1213 The same logic fixed in (nvim-lualine#1214) is duplicated in the lualine_require module, which appears to be used internally for loading things like extensions. On windows, user defined extensions that overwrite the builtin similarly cannot be loaded due to the same string matching issue. In addition, the number of queried runtime files is always less-than or equal to 1 due to the `all` parameter for `nvim_get_runtime_file` being set to false. Making it impossible to sort the list of files and prioritize ones within the users config path `vim.fn.stdpath("config")`.
|
Hi @shadmansaleh, I wanted to follow up on this PR which has been open for a few months. I understand you might be busy, but I’d appreciate it if you could take a look when you have the chance. Thanks! Upon reflection, the change from |
|
Thanks again. I didn't see this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the second part of: #1213
The same logic fixed in (#1214) is duplicated in the lualine_require module, which appears to be used internally for loading things like extensions.
On windows, user defined extensions that overwrite the builtins similarly cannot be loaded due to the same string matching issue. In addition, the number of queried runtime files is always less-than or equal to 1 due to the
allparameter fornvim_get_runtime_filebeing set tofalse. Making it impossible to sort the list of files and prioritize ones within the users config pathvim.fn.stdpath("config").