Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecma): add support for @return.inner, @return.outer and @statement.outer #683

Merged
merged 12 commits into from
Sep 27, 2024

Conversation

NikitaRevenco
Copy link
Contributor

@NikitaRevenco NikitaRevenco commented Sep 7, 2024

This includes js, ts, jsx, and tsx

Closes #686

@NikitaRevenco NikitaRevenco changed the title feat(ecma): add support for @return.inner and @return.outer feat(ecma): add support for @return.inner, @return.outer and @statement.outer Sep 7, 2024
@kiyoon
Copy link
Collaborator

kiyoon commented Sep 8, 2024

Note that you shouldn't change the README manually because there is an automatic CI that does it

@NikitaRevenco
Copy link
Contributor Author

Note that you shouldn't change the README manually because there is an automatic CI that does it

I have reverted changes to the Md file

@ribru17
Copy link
Member

ribru17 commented Sep 26, 2024

Would you mind running the query formatter? Then we can merge

@NikitaRevenco
Copy link
Contributor Author

Would you mind running the query formatter? Then we can merge

Ok!

@ribru17
Copy link
Member

ribru17 commented Sep 26, 2024

Thank you! Also one last thing, I apologize for not mentioning earlier- would you mind putting this in an alteration? It would probably be easier to read. Something like:

[
  (for_statement)
  (while_statement)
  ...etc
] @statement.outer

the return statement can stay on its own

@NikitaRevenco
Copy link
Contributor Author

Thank you! Also one last thing, I apologize for not mentioning earlier- would you mind putting this in an alteration? It would probably be easier to read. Something like:

[
  (for_statement)
  (while_statement)
  ...etc
] @statement.outer

the return statement can stay on its own

Sure!, I agree this makes it more reasonable. I wasn't even aware of this syntax till now, that's cool!

@ribru17 ribru17 merged commit a5c1cdb into nvim-treesitter:master Sep 27, 2024
6 checks passed
@ribru17
Copy link
Member

ribru17 commented Sep 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

javascript @return.inner, @return.outer, and @statement.outer support
3 participants