Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade browser-sync and resolve PersonaBar issue #360

Merged

Conversation

david-poindexter
Copy link
Member

Related to Issue

Fixes #355

Description

This PR upgrades browser-sync and adds a rewrite rule to allow the PersonaBar to show in DNN when using gulp serve.

How Has This Been Tested?

Local dev env

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@david-poindexter david-poindexter added the bug Something isn't working label Dec 29, 2023
@david-poindexter david-poindexter added this to the 3.1.0 milestone Dec 29, 2023
@david-poindexter david-poindexter self-assigned this Dec 29, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@david-poindexter david-poindexter merged commit 487ab80 into nvisionative:develop Dec 29, 2023
2 checks passed
@david-poindexter david-poindexter deleted the browser-sync-pb-fix branch December 29, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve issue with browsersync breaking the PersonaBar when logged in
1 participant