-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/416 Building Rework #418
base: master
Are you sure you want to change the base?
Conversation
df1e8e7
to
6c12224
Compare
A few issues with replacing rocks have been found:
I'm pretty sure that this makes the idea of replacing rocks a dead end. |
7d53984
to
e63abd8
Compare
After playing this some and thinking on it as well, I'm not entirely sure this is necessary. I've been forcing myself to play in higher ping situations on Battle.net, and the existing style of building is not that bad. I'm not sure the shift for players is entirely worth it. An alternative to Orc building may be Human building, which is visually closer to that of Undead. Then, introduce the concept of stopping construction if the builder moves away from the structure. That might make the change to building feel less foreign, as the builder will not be jumping into things. |
No real need to 'improve' human building. Perhaps, however, make the construction go faster. |
Issue: #416
Issue: #416 The old style utilize Undead construction. In short, the unit warped in out of nothing. This allowed players to 'fast build'. However, this style of building is difficult to use when latency is high. Removing it makes games with high ping less problematic for players, and should help the multiplayer situation. The new style will utilize Orc construction.
Issue: #416 In order to cancel construction, one must select the building being constructed. This, however, is error prone. There is a short time window in which to do this. One also must select the building. An alternative option would be to automatically select the unit. However, that prevents giving the building multiple orders. As such, we detect usage of the escape key. If the builder is selected and building, we cancel construction of the building.
It seems that the interface constants used to adjust the icons of the build menus do nothing. As such, there is no reason to attempt to change them. It should also be noted that attempting to change the icons in `CommandFunc.txt` also does nothing.
Issue: #416 The builder can make it difficult to select a placed gem. As such, we shift the builder out of the way, taking into account the various angles that visibility may be blocked.
Builder movement properly handles all gem placement scenarios. In short, those that were not aligned to `128` sized squares were ignored. This obviously allowed the builder to move to locations that should not have been considered. On top of it, the order of a few checks are swapped to improve performance.
b235de6
to
b5bc534
Compare
Note that this has been put on hold, and will not be in 1.6. Instead, we will see what future patches bring. |
Building Rework
Attempt at implementing #416.
Testing Version
This replaces the existing build style with Orc building.
Esc
can be used to cancel building while having the builder selected (which it will be if he has just gone inside to build). Probably want to utilizeShift
to queue up build orders.This has the potential to be slower than the older style, depending on the player (i.e. if you use fast building it may feel slower). I've noticed, however, that this also increases my ability to recognize and respond to one-hits. Overall, races should be more competitive as building speed (and probably ping) won't factor in as heavily.
To-Do
Notes
Options
Replacing rocks using the built in haunt style.This is not viable, as discussed in Feature/416 Building Rework #418 (comment). Request made to improve the usability of this action made here at Hive.Esc
key can be detected to make cancelling construction easier. I foresee a heavier use ofShift
to queue up build orders.This is potentially slower than the older style. I've noticed that this also increases my ability to recognize and respond to one-hits. Times will be slower, however, for players used to fast building. But, overall, races should be more competitive as building won't factor in as heavily.
Seems to be much easier to use (probably due to the slower pace) in high ping situations. I've made far fewer mistakes in such situations. This may help foster competition on Battle.net where people could be from anywhere around the world, as they may be less inclined to avoid certain hosts.
In a situation with an explicit roll ability, the placement phase would not really exist. All that would exist is the planning phase (which would begin the moment a round starts until that roll ability it used), and the selection phase (which entails picking from one of the random gems).
Thoughts
I would prefer to have the ability to replace rocks via haunt (Option 1). All in all, it keeps things simple. The responsibility of placing gems, either by building or replacing, would remain with the builder. Putting a replace ability onto rocks (as in Option 5) splits the responsibility. Yes, that may seem an obvious choice to some players. And, it may be the eventual course taken. But I'm not a fan.
Now, I do like Option 3. But it is a more drastic change. It remains to be seen whether the addition of such complexity is warranted, or whether it would feel good in practice. Option 4 is not really a choice. And Option 2 makes a good simple change; albeit, people may fret over change. Particularly, the speed involved. The benefits outweigh the cost, however (see #416).
So, if Blizzard comes through with the request related to Option 1, that will be introduced. Regardless, I feel that Option 2 alone is the best course right now. And Option 1 can always be added alongside it at a later date.