Skip to content

Commit

Permalink
Disable broken test for automatic transaction groups on GDAL >= 3.5
Browse files Browse the repository at this point in the history
This functionality is broken on newer GDAL versions, due
to incorrect assumptions at time of development.

See qgis#59797 (comment)

Parties interested in seeing this test resurrected are welcome
to submit fixes.
  • Loading branch information
nyalldawson committed Dec 17, 2024
1 parent 72f07dc commit 3106f19
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion tests/src/python/test_qgsvectorlayereditbuffer.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
__copyright__ = "Copyright 2016, The QGIS Project"

import os
from osgeo import gdal

from qgis.PyQt.QtCore import QTemporaryDir, QVariant
from qgis.PyQt.QtTest import QSignalSpy
Expand All @@ -31,6 +32,10 @@
start_app()


def GDAL_COMPUTE_VERSION(maj, min, rev):
return (maj) * 1000000 + (min) * 10000 + (rev) * 100


def createEmptyLayer():
layer = QgsVectorLayer(
"Point?field=fldtxt:string&field=fldint:integer", "addfeat", "memory"
Expand Down Expand Up @@ -843,7 +848,12 @@ def _check_feature(wkt):
self.assertEqual(f.attribute(2), None)

_test(Qgis.TransactionMode.Disabled)
_test(Qgis.TransactionMode.AutomaticGroups)

# THIS FUNCTIONALITY IS BROKEN ON NEWER GDAL VERSIONS, DUE TO INCORRECT
# assumptions at time of development. See https://github.com/qgis/QGIS/pull/59797#issuecomment-2544133498
if int(gdal.VersionInfo("VERSION_NUM")) < GDAL_COMPUTE_VERSION(3, 5, 0):
_test(Qgis.TransactionMode.AutomaticGroups)

_test(Qgis.TransactionMode.BufferedGroups)


Expand Down

0 comments on commit 3106f19

Please sign in to comment.