Re-enable windows for nym-vpn-core CI and release #1401
Conversation
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @octol)
pronebird
force-pushed
the
jon/reenable-windows-ci
branch
from
ae38112
to
5df2a1f
Compare
pronebird
force-pushed
the
jon/reenable-windows-ci
branch
from
dd4e106
to
18c68fb
Compare
|
Main build is all green: https://github.com/nymtech/nym-vpn-client/actions/runs/11568586122/job/32201088230 |
| run: | | ||
| triplet=x86_64-pc-windows-msvc | ||
| echo "TRIPLET=$triplet" >> $GITHUB_ENV | ||
| echo "RUSTFLAGS=-L ${GITHUB_WORKSPACE}/build/lib -Clink-args=/LIBPATH:${GITHUB_WORKSPACE}/build/lib/x64-Debug" >> $GITHUB_ENV |
There was a problem hiding this comment.
I thought we didn't need this anymore @pronebird ?
There was a problem hiding this comment.
oh I see now, it's for winfw et al
| shell: bash | ||
| run: | | ||
| curl --output ${GITHUB_WORKSPACE}/wintun.zip https://www.wintun.net/builds/wintun-0.14.1.zip | ||
| curl --output ${GITHUB_WORKSPACE}/winpcap.zip https://www.winpcap.org/install/bin/WpdPack_4_1_2.zip |
There was a problem hiding this comment.
I think this one is unused, let me try removing it
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 1 of 7 files reviewed, 1 unresolved discussion
.github/workflows/ci-nym-vpn-core-windows.yml line 45 at r8 (raw file):
Previously, octol (Jon Häggblad) wrote…
oh I see now, it's for winfw et al
Yes. Some of the firewall libs are put in there. We don't really use firewall but I didn't want to remove these steps because soon we'll need them again.
This change is