Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error response when fetching discovery endpoint #1452

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

octol
Copy link
Contributor

@octol octol commented Nov 3, 2024

  • When fetching the discovery endpoint, to fail if it doesn't succeed. Instead try to use what we have cached locally.
  • Include default values compiled from local json file
  • Initial implementation for network lists

This change is Reviewable

@octol octol requested a review from neacsu November 4, 2024 09:54
@octol octol force-pushed the jon/discovery-request-display-error branch from f38ffb6 to a7055f1 Compare November 4, 2024 09:57
@octol octol changed the base branch from main to release/2024.1 November 4, 2024 11:34
@octol octol merged commit b30a6c9 into release/2024.1 Nov 5, 2024
11 checks passed
@octol octol deleted the jon/discovery-request-display-error branch November 5, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants