[Product Data] Reports exit country and tickets #1565
+147
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neacsu
reviewed
Nov 14, 2024
| if let Some(exit_country_code) = selected_gateways.exit.two_letter_iso_country_code() { | ||
| self.mixnet_client | ||
| .send_stats_event( | ||
| ConnectionStatsEvent::MixCountry(exit_country_code.to_string()).into(), |
There was a problem hiding this comment.
Doesn't this heavily deanonymises the mixnet mode of the vpn, by creating a link between mixnet client's identity and the exit gateway? At least in the current state, where SURBs are not implemented for mixnet mode.
There was a problem hiding this comment.
So this info gets sent to the aggregator and the report including this is sent through the mixer, with a stats id, hashed from the identity.
You're indeed reducing the set of gateway you might be connected to, but you're not doxing yourself by revealing your entry gateway
simonwicky
force-pushed
the
simon/connection_stats
branch
from
54f5f85
to
ad6a6d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add reporting of exit country and tickets used.
This PR requires nymtech/nym#5134 to be merged first
This change is