-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/reg over mix #633
Feature/reg over mix #633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor maintainability comments for sometimes, otherwise looks good
let mut mixnet_client_handle = self.mixnet_client.lock().await; | ||
let mixnet_client = mixnet_client_handle.as_mut().unwrap(); | ||
|
||
let timeout = tokio::time::sleep(Duration::from_secs(5)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to make this configurable? Something to keep in mind for the future
} | ||
} | ||
|
||
fn check_auth_message_version(message: &ReconstructedMessage) -> Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather have this a proper struct (the whole message), but we can leave it for a future iteration
} | ||
} | ||
|
||
pub fn extract_authenticator( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, love it
No description provided.