Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reg over mix #633

Merged
merged 22 commits into from
Jul 16, 2024
Merged

Feature/reg over mix #633

merged 22 commits into from
Jul 16, 2024

Conversation

neacsu
Copy link
Collaborator

@neacsu neacsu commented Jul 4, 2024

No description provided.

@neacsu neacsu marked this pull request as ready for review July 12, 2024 16:20
nym-vpn-core/nym-vpn-lib/src/error.rs Outdated Show resolved Hide resolved
nym-vpn-core/nym-vpn-lib/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@durch durch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor maintainability comments for sometimes, otherwise looks good

let mut mixnet_client_handle = self.mixnet_client.lock().await;
let mixnet_client = mixnet_client_handle.as_mut().unwrap();

let timeout = tokio::time::sleep(Duration::from_secs(5));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make this configurable? Something to keep in mind for the future

}
}

fn check_auth_message_version(message: &ReconstructedMessage) -> Result<()> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have this a proper struct (the whole message), but we can leave it for a future iteration

}
}

pub fn extract_authenticator(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, love it

@neacsu neacsu merged commit 8ef66c7 into main Jul 16, 2024
23 checks passed
@neacsu neacsu deleted the feature/reg_over_mix branch July 16, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants