Skip to content

Commit

Permalink
bump 5.0.8 (#359)
Browse files Browse the repository at this point in the history
  • Loading branch information
mr-fixit authored Oct 31, 2022
1 parent 6958d35 commit e807f8c
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 40 deletions.
7 changes: 7 additions & 0 deletions .swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## [5.0.8](https://github.com/nytimes/NYTPhotoViewer/releases/tag/5.0.8)

Changes for users of the library currently on `5.0.8`:
- using metadata to add summary to share activity

Expand Down
18 changes: 10 additions & 8 deletions Documentation/Release Process.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,18 @@ _While tagging a new version of a library and pushing it to CocoaPods is concept

# NYTPhotoViewer Release Process

- Review [the diff between `master` and `develop`](https://github.com/NYTimes/NYTPhotoViewer/compare/master...develop) to determine which part of the version number to increment, in accordance with [semantic versioning](http://semver.org/).
- Review the diff between `the last tag` and `develop` to determine which part of the version number to increment, in accordance with [semantic versioning](http://semver.org/).
- Create a branch off the commit in develop (probably HEAD) you wish to release.
- Update [the Podspec](https://github.com/NYTimes/NYTPhotoViewer/blob/develop/NYTPhotoViewer.podspec) to the new version number.
- Make this change via a pull request to trigger notifications for those who watch the repository.
- Using [the diff](https://github.com/NYTimes/NYTPhotoViewer/compare/master...develop), [the commit history](https://github.com/NYTimes/NYTPhotoViewer/commits/develop), and any notes about `develop` which may have been written in the `CHANGELOG`, update [`CHANGELOG.md`](https://github.com/NYTimes/NYTPhotoViewer/blob/develop/CHANGELOG.md) with changes in the new version which may affect library users.
- Using the diff above and any notes about `develop` which may have been written in the `CHANGELOG`, update [`CHANGELOG.md`](https://github.com/NYTimes/NYTPhotoViewer/blob/develop/CHANGELOG.md) with changes in the new version which may affect library users.
- When reviewing the commit history, searching for “Merge pull request” helps find changes which should appear in [the `CHANGELOG`](https://github.com/NYTimes/NYTPhotoViewer/blob/develop/CHANGELOG.md).
- Update any other documentation which still needs to be updated, given those changes.
- Create a pull request merging [`develop` into `master`](https://github.com/NYTimes/NYTPhotoViewer/compare/master...develop). Merge it yourself, immediately.
- Create a [Github release](https://github.com/NYTimes/NYTPhotoViewer/releases), using the new version number (eg. `1.0.0`) as the tag, and the merge commit into `master` as the target. Copy [the `CHANGELOG`](https://raw.githubusercontent.com/NYTimes/NYTPhotoViewer/develop/CHANGELOG.md)’s Markdown content for this release into the Github release.
- Push the new Podspec to Cocoapods Trunk: `pod trunk push NYTPhotoViewer.podspec`
- Ensure your local clone is up-to-date before this push.
- Update any other documentation.
- Commit the above changes to your branch, suggested message "bump v<new version>"
- Create a pull request to merge your branch into `develop`. This will trigger notifications for those who watch the repository.
- Once that PR is merged:
- Create a [Github release](https://github.com/NYTimes/NYTPhotoViewer/releases), using the new version number (eg. `1.0.0`) as the tag, and the merge commit into `master` as the target. Copy [the `CHANGELOG`](https://raw.githubusercontent.com/NYTimes/NYTPhotoViewer/develop/CHANGELOG.md)’s Markdown content for this release into the Github release.
- Ensure your local clone is up-to-date on `develop`
- Push the new Podspec to Cocoapods Trunk: `pod trunk push NYTPhotoViewer.podspec`.

## CocoaPods Trunk Setup

Expand Down
2 changes: 1 addition & 1 deletion NYTPhotoViewer.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "NYTPhotoViewer"
s.version = "5.0.7"
s.version = "5.0.8"

s.description = <<-DESC
NYTPhotoViewer is a slideshow and image viewer that includes double tap to zoom, captions, support for multiple images, interactive flick to dismiss, animated zooming presentation, and more.
Expand Down
31 changes: 0 additions & 31 deletions bitrise.yml

This file was deleted.

0 comments on commit e807f8c

Please sign in to comment.