Skip to content

Commit

Permalink
o1vm/riscv32: implement mul_hi_signed_unsigned to be used for Mulhsu
Browse files Browse the repository at this point in the history
  • Loading branch information
dannywillems committed Dec 3, 2024
1 parent 4c5bff9 commit 1708293
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 0 deletions.
9 changes: 9 additions & 0 deletions o1vm/src/interpreters/riscv32im/constraints.rs
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,15 @@ impl<Fp: Field> InterpreterEnv for Env<Fp> {
self.variable(position)
}

unsafe fn mul_hi_signed_unsigned(
&mut self,
_x: &Self::Variable,
_y: &Self::Variable,
position: Self::Position,
) -> Self::Variable {
self.variable(position)
}

unsafe fn div_signed(
&mut self,
_x: &Self::Variable,
Expand Down
14 changes: 14 additions & 0 deletions o1vm/src/interpreters/riscv32im/interpreter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1257,6 +1257,20 @@ pub trait InterpreterEnv {
position: Self::Position,
) -> Self::Variable;

/// Returns `((x * y) >> 32`, storing the results in `position`.
///
/// # Safety
///
/// There are no constraints on the returned values; callers must manually add constraints to
/// ensure that the pair of returned values correspond to the given values `x` and `y`, and
/// that they fall within the desired range.
unsafe fn mul_hi_signed_unsigned(
&mut self,
x: &Self::Variable,
y: &Self::Variable,
position: Self::Position,
) -> Self::Variable;

/// Returns `x / y`, storing the results in `position`.
///
/// # Safety
Expand Down
15 changes: 15 additions & 0 deletions o1vm/src/interpreters/riscv32im/witness.rs
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,21 @@ impl<Fp: Field> InterpreterEnv for Env<Fp> {
res
}

unsafe fn mul_hi_signed_unsigned(
&mut self,
x: &Self::Variable,
y: &Self::Variable,
position: Self::Position,
) -> Self::Variable {
let x: u32 = (*x).try_into().unwrap();
let y: u32 = (*y).try_into().unwrap();
let res = (((x as i32) as i64) * (y as i64)) as u64;
let res = (res >> 32) as u32;
let res = res as u64;
self.write_column(position, res);
res
}

unsafe fn div_signed(
&mut self,
x: &Self::Variable,
Expand Down

0 comments on commit 1708293

Please sign in to comment.