Merge pull request #2541 from o1-labs/tests/mvpoly-generic-trait

MVPoly tests generalization based on example.
o1-labs · Sep 9, 2024 · 1a72f3f · 1a72f3f
2 parents 590ec1b + 465ef3b
commit 1a72f3f
Show file tree

Hide file tree

Showing 6 changed files with 473 additions and 438 deletions.
diff --git a/mvpoly/src/lib.rs b/mvpoly/src/lib.rs
@@ -5,6 +5,7 @@ use kimchi::circuits::expr::{ConstantExpr, Expr};
 use rand::RngCore;
 
 pub mod monomials;
+pub mod pbt;
 pub mod prime;
 pub mod utils;
 
@@ -17,6 +18,7 @@ pub trait MVPoly<F: PrimeField, const N: usize, const D: usize>:
     + ark_ff::One
     + ark_ff::Zero
     + std::fmt::Debug
+    + Clone
     // Comparison operators
     + PartialEq
     + Eq
@@ -106,4 +108,6 @@ pub trait MVPoly<F: PrimeField, const N: usize, const D: usize>:
         u1: F,
         u2: F,
     ) -> HashMap<usize, F>;
+
+    fn modify_monomial_with_scalar(&mut self, scalar: F);
 }
diff --git a/mvpoly/src/monomials.rs b/mvpoly/src/monomials.rs
@@ -564,6 +564,10 @@ impl<const N: usize, const D: usize, F: PrimeField> MVPoly<F, N, D> for Sparse<F
         });
         cross_terms_by_powers_of_r
     }
+
+    fn modify_monomial_with_scalar(&mut self, scalar: F) {
+        self.modify_monomial([0; N], scalar);
+    }
 }
 
 impl<const N: usize, const D: usize, F: PrimeField> From<prime::Dense<F, N, D>>