Merge pull request #2859 from o1-labs/sai/branch-gte

implementation for branch greater than or equal
o1-labs · Dec 24, 2024 · 2f134fb · 2f134fb
2 parents f170ebe + 5efc2f8
commit 2f134fb
Showing 1 changed file with 28 additions and 1 deletion.
diff --git a/o1vm/src/interpreters/riscv32im/interpreter.rs b/o1vm/src/interpreters/riscv32im/interpreter.rs
@@ -2296,7 +2296,34 @@ pub fn interpret_sbtype<Env: InterpreterEnv>(env: &mut Env, instr: SBInstruction
             env.set_next_instruction_pointer(addr);
         }
         SBInstruction::BranchGreaterThanEqual => {
-            unimplemented!("BranchGreaterThanEqual")
+            // bge: if (x[rs1] >= x[rs2]) pc += sext(offset)
+            let local_rs1 = env.read_register(&rs1);
+            let local_rs2 = env.read_register(&rs2);
+
+            let less_than = {
+                let rd_scratch = env.alloc_scratch();
+                unsafe { env.test_less_than_signed(&local_rs1, &local_rs2, rd_scratch) }
+            };
+
+            let offset =
+                less_than.clone() * Env::constant(4) + (Env::constant(1) - less_than) * imm0_12;
+            // greater than equal is the negation of less than
+            let addr = {
+                let res_scratch = env.alloc_scratch();
+                let overflow_scratch = env.alloc_scratch();
+                let (res, _overflow) = unsafe {
+                    env.add_witness(
+                        &next_instruction_pointer,
+                        &offset,
+                        res_scratch,
+                        overflow_scratch,
+                    )
+                };
+                // FIXME: Requires a range check
+                res
+            };
+            env.set_instruction_pointer(next_instruction_pointer);
+            env.set_next_instruction_pointer(addr);
         }
         SBInstruction::BranchLessThanUnsigned => {
             unimplemented!("BranchLessThanUnsigned")