Skip to content

Commit

Permalink
Merge Marc's work
Browse files Browse the repository at this point in the history
  • Loading branch information
Fizzixnerd committed Jan 13, 2025
1 parent 487da00 commit 681455f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions o1vm/src/interpreters/mips/column.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,14 @@ pub enum ColumnAlias {
Selector(usize),
Lookup(LookupTableID, usize),
// TODO add
/* LookupPartialSum((u32, usize)),
LookupPartialSum((u32, usize)),
/// Multiplicities, indexed. This corresponds to the `m_i`. First
/// indexed by table ID, then internal index.
LookupMultiplicity((u32, usize)),
/// The lookup aggregation, i.e. `phi`
LookupAggregation,
/// The fixed tables. The parameter is considered to the indexed table.
LookupFixedTable(u32), */
LookupFixedTable(u32),
}

/// The columns used by the MIPS circuit. The MIPS circuit is split into three
Expand Down
3 changes: 1 addition & 2 deletions o1vm/src/interpreters/mips/constraints.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ use kimchi::circuits::{
};
use std::{array, collections::HashMap};
use strum::IntoEnumIterator;

use super::column::N_MIPS_SEL_COLS;

/// The environment keeping the constraints between the different polynomials
Expand Down Expand Up @@ -69,7 +68,7 @@ impl<Fp: Field> InterpreterEnv for Env<Fp> {

fn alloc_lookup(&mut self, table_id: LookupTableID) -> Self::Position {
let idx = self.scratch_lookups.get_mut(&table_id).unwrap();
*idx = *idx + 1;
*idx += 1;
MIPSColumn::Lookup(table_id, *idx - 1)
// TODO
}
Expand Down

0 comments on commit 681455f

Please sign in to comment.