Skip to content

Commit

Permalink
Merge pull request #2771 from o1-labs/dw/implement-sll-riscv32
Browse files Browse the repository at this point in the history
o1vm/riscv32: implement R type instruction sll
  • Loading branch information
dannywillems authored Nov 20, 2024
2 parents 58fbae4 + 6ec50cd commit 75bb37a
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion o1vm/src/interpreters/riscv32im/interpreter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1312,7 +1312,17 @@ pub fn interpret_rtype<Env: InterpreterEnv>(env: &mut Env, instr: RInstruction)
env.set_next_instruction_pointer(next_instruction_pointer + Env::constant(4u32));
}
RInstruction::ShiftLeftLogical => {
unimplemented!("ShiftLeftLogical");
/* sll: x[rd] = x[rs1] << x[rs2] */
let local_rs1 = env.read_register(&rs1);
let local_rs2 = env.read_register(&rs2);
let local_rd = unsafe {
let rd_scratch = env.alloc_scratch();
env.shift_left(&local_rs1, &local_rs2, rd_scratch)
};
env.write_register(&rd, local_rd);

env.set_instruction_pointer(next_instruction_pointer.clone());
env.set_next_instruction_pointer(next_instruction_pointer + Env::constant(4u32));
}
RInstruction::SetLessThan => {
unimplemented!("SetLessThan");
Expand Down

0 comments on commit 75bb37a

Please sign in to comment.