-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to arkworks 0.4.2 (mina compatible / p-s develop) #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volhovm
force-pushed
the
volhovm/arkworks042-compatible
branch
from
August 16, 2024 13:51
58c5661
to
56a5204
Compare
This was referenced Aug 19, 2024
volhovm
force-pushed
the
volhovm/arkworks042-compatible
branch
from
August 20, 2024 12:50
56a5204
to
2f0186a
Compare
Oh boy 😨 |
volhovm
force-pushed
the
volhovm/arkworks042-compatible
branch
2 times, most recently
from
August 27, 2024 11:24
5d7c665
to
f968131
Compare
volhovm
force-pushed
the
volhovm/arkworks042-compatible
branch
from
September 11, 2024 12:14
f968131
to
6866340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo comment. Not approving because of circuit-construction.
dannywillems
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing the epic PR now on top of the most recent proof-system's
develop
which maps to mina'scompatible
.