Add serde_as regression test for pasta #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volhovm
force-pushed
the
volhovm/add-regression-for-pasta-serialization
branch
from
8d9fcd2 to
7cd2acf
Compare
dkijania
reviewed
Aug 22, 2024
utils/src/serialization.rs
Outdated
|
|
||
| let mut buf_written: Vec<u8> = vec![0; buf_expected.len()]; | ||
|
|
||
| let srs_bytes = rmp_serde::to_vec(&data_expected).unwrap(); |
There was a problem hiding this comment.
Nit pick: don't use unwrap() but expects. Generally it's easier to find what is wrong if you have more than one unwrap() in the test
volhovm
commented
Aug 22, 2024
| @@ -122,7 +122,6 @@ where | |||
| } | |||
|
|
|||
| /// creates the indexes | |||
| #[must_use] | |||
There was a problem hiding this comment.
Offtop but: I removed this since it was giving a warning: setup_with_custom_srs is indeed used, but only in tests. must_use does not understand this and produces a warning.
dkijania
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test to make sure that serialization of pasta points is as we expect.
(important for making sure update to arkworks 0.4.2 is not breaking backward-compatibility)