Arkworks 0.4.2: fix test vectors serialization issue #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volhovm
force-pushed
the
volhovm/arkworks042-develop-fix-export-test-vectors
branch
from
8d33f7a to
c271f38
Compare
volhovm
force-pushed
the
volhovm/arkworks042-develop-fix-export-test-vectors
branch
from
c271f38 to
18a63c3
Compare
| 205, 238, 73, 116, 220, 196, 21, 134, 120, 39, 171, 177, 119, 25, | ||
| ], | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Can you add the commit the values have been generated with? It is a good practice when adding regression tests. In particular, the commit should be one before the test has been written.
There was a problem hiding this comment.
Feel free to do it in a follow-up.
dannywillems
approved these changes
Sep 23, 2024
|
@dannywillems thanks! Yes, I did |
volhovm
force-pushed
the
volhovm/arkworks042-develop-fix-export-test-vectors
branch
from
18a63c3 to
3e2e36f
Compare
volhovm
deleted the
volhovm/arkworks042-develop-fix-export-test-vectors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: in
export_test_vectorsinstead of (f_elem.into_repr() -> f_elem.into_bigint()) the renaming during the arkworks upgrade was mistakenly (f_elem.into_repr() -> f_elem.0), which also returns a bigint, but it's a different bigint!I also scanned for all
into_repr()renamings in the original arkworks PR diff and only found another similar issue infield_helpers, but there it's immaterial (fixed anyway).Regression test confirmed to work on
1494cf973d40fb276465929eb7db1952c5de7bdc(last commit ondevelopbefore arkworks 0.4.2).