-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
o1vm/pickles: Remove linearization and add quotient polynomial evaluations #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be better to have them instead of having randomly the value popping up in the code at different places.
Fizzixnerd
force-pushed
the
fizzixnerd/dw/continue-quotient-polynomial
branch
from
October 9, 2024 17:40
21ff649
to
7ad0d33
Compare
Fizzixnerd
force-pushed
the
fizzixnerd/dw/continue-quotient-polynomial
branch
from
October 9, 2024 17:44
7ad0d33
to
a4a47c0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2692 +/- ##
==========================================
+ Coverage 72.53% 72.55% +0.01%
==========================================
Files 246 246
Lines 58191 58224 +33
==========================================
+ Hits 42209 42242 +33
Misses 15982 15982 ☔ View full report in Codecov by Sentry. |
Fizzixnerd
force-pushed
the
fizzixnerd/dw/continue-quotient-polynomial
branch
from
October 9, 2024 18:56
9581283
to
9f649e1
Compare
I ended up adding it after talking with @marcbeunardeau88 on Slack. |
dannywillems
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Reviewer: I didn't add the quotient polynomial to the OpeningProof. Not sure if it's needed, but will if it is.