Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/pickles: Remove linearization and add quotient polynomial evaluations #2692

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

Fizzixnerd
Copy link
Contributor

To Reviewer: I didn't add the quotient polynomial to the OpeningProof. Not sure if it's needed, but will if it is.

@Fizzixnerd Fizzixnerd force-pushed the fizzixnerd/dw/continue-quotient-polynomial branch from 21ff649 to 7ad0d33 Compare October 9, 2024 17:40
@Fizzixnerd Fizzixnerd force-pushed the fizzixnerd/dw/continue-quotient-polynomial branch from 7ad0d33 to a4a47c0 Compare October 9, 2024 17:44
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.55%. Comparing base (0e68ddc) to head (9f649e1).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/pickles/prover.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2692      +/-   ##
==========================================
+ Coverage   72.53%   72.55%   +0.01%     
==========================================
  Files         246      246              
  Lines       58191    58224      +33     
==========================================
+ Hits        42209    42242      +33     
  Misses      15982    15982              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fizzixnerd Fizzixnerd force-pushed the fizzixnerd/dw/continue-quotient-polynomial branch from 9581283 to 9f649e1 Compare October 9, 2024 18:56
@Fizzixnerd
Copy link
Contributor Author

I ended up adding it after talking with @marcbeunardeau88 on Slack.

@Fizzixnerd Fizzixnerd self-assigned this Oct 9, 2024
@Fizzixnerd Fizzixnerd merged commit 09cf803 into master Oct 9, 2024
7 checks passed
@Fizzixnerd Fizzixnerd deleted the fizzixnerd/dw/continue-quotient-polynomial branch October 9, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants