Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrabiata: remove old gadgets #2698

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Arrabiata: remove old gadgets #2698

merged 3 commits into from
Oct 14, 2024

Conversation

dannywillems
Copy link
Member

These are leftovers from the initial draft of Arrabiata. The gadgets won't be used.
If we want to get them back, we can always revert the commit. But for now, I would remove them to clean the code.

@dannywillems dannywillems force-pushed the dw/remove-old-gadgets branch from bdcc50f to a4e6615 Compare October 10, 2024 10:58
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.42%. Comparing base (653dbc2) to head (d13ecf4).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
arrabiata/src/columns.rs 0.00% 1 Missing ⚠️
arrabiata/src/witness.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2698      +/-   ##
==========================================
- Coverage   72.52%   72.42%   -0.10%     
==========================================
  Files         246      246              
  Lines       58241    58055     -186     
==========================================
- Hits        42238    42046     -192     
- Misses      16003    16009       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dannywillems dannywillems force-pushed the dw/remove-old-gadgets branch from 4cd4d36 to d13ecf4 Compare October 10, 2024 13:22
Base automatically changed from dw/constraints-activate-gadget-arrabiata to master October 14, 2024 15:57
@dannywillems dannywillems merged commit 146e1c3 into master Oct 14, 2024
6 of 7 checks passed
@dannywillems dannywillems deleted the dw/remove-old-gadgets branch October 14, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants