Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kimchi/expr: misc cleaning + remove unused methods #2707

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dannywillems
Copy link
Member

No description provided.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 72.53%. Comparing base (ff3359e) to head (3736db0).
Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
kimchi/src/circuits/expr.rs 13.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2707      +/-   ##
==========================================
+ Coverage   72.51%   72.53%   +0.01%     
==========================================
  Files         246      246              
  Lines       58268    58233      -35     
==========================================
- Hits        42255    42239      -16     
+ Misses      16013    15994      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dannywillems dannywillems requested a review from shimkiv October 15, 2024 14:38
@dannywillems dannywillems merged commit 519bfa5 into master Oct 15, 2024
7 checks passed
@dannywillems dannywillems deleted the dw/more-clean-expr branch October 15, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants