o1vm/riscv32im: start checking the nb of csts per instruction #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/o1vm/check-nb-constraints
branch
from
04516fa to
22649ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2864 +/- ##
==========================================
+ Coverage 73.45% 74.68% +1.23%
==========================================
Files 259 259
Lines 61593 61667 +74
==========================================
+ Hits 45243 46058 +815
+ Misses 16350 15609 -741 ☔ View full report in Codecov by Sentry. |
svv232
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To investigate later under-constrained instructions. Lookups still need to be added.