mvpoly: introduce optional param upper bound to compute nested loops #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
mvpoly/param-compute-nested-loop-degree-bound
branch
from
05c2cbf to
597a664
Compare
dannywillems
force-pushed
the
mvpoly/remove-flaky-test
branch
from
2d497c5 to
eb0c6a9
Compare
querolita
approved these changes
Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2872 +/- ##
==========================================
- Coverage 72.02% 72.02% -0.01%
==========================================
Files 257 257
Lines 60732 60720 -12
==========================================
- Hits 43741 43731 -10
+ Misses 16991 16989 -2 ☔ View full report in Codecov by Sentry. |
dannywillems
changed the base branch from
mvpoly/remove-flaky-test
to
mvpoly/improve-gen-random
Oopsie. Lemme rebase. Nice catch. |
using filter_map speeds up the computation by avoiding creating a bigger map than expected if a low upper bound is given with large number of indices.
dannywillems
force-pushed
the
mvpoly/param-compute-nested-loop-degree-bound
branch
from
597a664 to
ac2500f
Compare
Should be better now. |
dannywillems
deleted the
mvpoly/param-compute-nested-loop-degree-bound
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using filter_map speeds up the computation by avoiding creating a bigger map than expected if a low upper bound is given with large number of indices.
Cherry-picked from #2702