Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional PreImageOracle #2920

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Optional PreImageOracle #2920

merged 1 commit into from
Jan 2, 2025

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Jan 2, 2025

Not every mips program requires this, but we currently throw an exception if it isn't provided

Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now. It is not the best solution as we discussed, but it works, and help to get something working.

We will also need to change it when we integrate the prover/verifier for RISC-V.

Also, we need a better solution to handle MIPS programs that are not targeting OP (i.e. no oracle for instance). We might want to have in the future a different subinterpreter for the syscalls..

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 74.66%. Comparing base (84c1103) to head (343132b).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/legacy/main.rs 0.00% 15 Missing ⚠️
o1vm/src/pickles/main.rs 0.00% 15 Missing ⚠️
o1vm/src/preimage_oracle.rs 0.00% 11 Missing ⚠️
o1vm/src/test_preimage_read.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2920      +/-   ##
==========================================
+ Coverage   73.44%   74.66%   +1.21%     
==========================================
  Files         259      259              
  Lines       61618    61713      +95     
==========================================
+ Hits        45253    46075     +822     
+ Misses      16365    15638     -727     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martyall martyall merged commit eb80434 into master Jan 2, 2025
8 checks passed
@martyall martyall deleted the optional-preimage-oracle branch January 2, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants