Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm: remove legacy flavor #2922

Merged
merged 1 commit into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions o1vm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ license = "Apache-2.0"
[lib]
path = "src/lib.rs"

[[bin]]
name = "legacy_o1vm"
path = "src/legacy/main.rs"

[[bin]]
name = "pickles_o1vm"
path = "src/pickles/main.rs"
Expand Down
1 change: 0 additions & 1 deletion o1vm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ In either case, `run-code.sh` will:

Different versions/flavors of the o1vm are available.

- [legacy](./src/legacy/mod.rs) - to be deprecated.
- [pickles](./src/pickles/mod.rs) (currently the default)

You can select the flavor you want to run with `run-code.sh` by using the
Expand Down
50 changes: 12 additions & 38 deletions o1vm/src/interpreters/keccak/environment.rs
Original file line number Diff line number Diff line change
@@ -1,25 +1,19 @@
//! This module contains the definition and implementation of the Keccak environment
//! including the common functions between the witness and the constraints environments
//! for arithmetic, boolean, and column operations.
use crate::{
interpreters::keccak::{
column::{
Absorbs::{self, *},
KeccakWitness,
Sponges::{self, *},
Steps,
Steps::*,
PAD_SUFFIX_LEN,
},
constraints::Env as ConstraintsEnv,
grid_index,
interpreter::KeccakInterpreter,
pad_blocks, standardize,
witness::Env as WitnessEnv,
KeccakColumn, DIM, HASH_BYTELENGTH, QUARTERS, WORDS_IN_HASH,
use crate::interpreters::keccak::{
column::{
Absorbs::{self, *},
KeccakWitness,
Sponges::{self, *},
Steps,
Steps::*,
PAD_SUFFIX_LEN,
},
lookups::Lookup,
E,
constraints::Env as ConstraintsEnv,
grid_index, pad_blocks, standardize,
witness::Env as WitnessEnv,
KeccakColumn, DIM, HASH_BYTELENGTH, QUARTERS, WORDS_IN_HASH,
};

use ark_ff::Field;
Expand Down Expand Up @@ -437,24 +431,4 @@ impl<F: Field> KeccakEnv<F> {

state_g
}

/// Returns the list of constraints used in a specific Keccak step
pub(crate) fn constraints_of(step: Steps) -> Vec<E<F>> {
let mut env = ConstraintsEnv {
constraints: vec![],
lookups: vec![],
};
env.constraints(step);
env.constraints
}

/// Returns the list of lookups used in a specific Keccak step
pub(crate) fn lookups_of(step: Steps) -> Vec<Lookup<E<F>>> {
let mut env = ConstraintsEnv {
constraints: vec![],
lookups: vec![],
};
env.lookups(step);
env.lookups
}
}
Loading
Loading