Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv batch inverse #2939

Merged
merged 4 commits into from
Jan 8, 2025
Merged

riscv batch inverse #2939

merged 4 commits into from
Jan 8, 2025

Conversation

svv232
Copy link
Member

@svv232 svv232 commented Jan 8, 2025

No description provided.

@svv232 svv232 requested a review from dannywillems January 8, 2025 16:09
@@ -1,5 +1,6 @@
/// The minimal number of columns required for the VM
pub const SCRATCH_SIZE: usize = 39;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up: this can be decreased then.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 67.21311% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@39a3b5d). Learn more about missing BASE report.
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/interpreters/riscv32im/witness.rs 53.12% 15 Missing ⚠️
o1vm/src/interpreters/riscv32im/column.rs 73.68% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2939   +/-   ##
=========================================
  Coverage          ?   76.61%           
=========================================
  Files             ?      255           
  Lines             ?    60869           
  Branches          ?        0           
=========================================
  Hits              ?    46636           
  Misses            ?    14233           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svv232 svv232 merged commit b947c28 into master Jan 8, 2025
11 checks passed
@svv232 svv232 deleted the sai/batch-inverse-riscv branch January 8, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants