Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterise Column #2948

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Parameterise Column #2948

merged 3 commits into from
Jan 13, 2025

Conversation

mrmr1993
Copy link
Member

This PR adds a parameter to Column, letting us use saner types in place of usize where appropriate. This PR is a no-op, retaining the use of usize everywhere for now.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.61%. Comparing base (2136d6c) to head (21c8196).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
ivc/src/expr_eval.rs 0.00% 4 Missing ⚠️
ivc/src/plonkish_lang.rs 0.00% 1 Missing ⚠️
ivc/src/prover.rs 0.00% 1 Missing ⚠️
ivc/src/verifier.rs 0.00% 1 Missing ⚠️
msm/src/expr.rs 75.00% 1 Missing ⚠️
o1vm/src/interpreters/keccak/column.rs 50.00% 1 Missing ⚠️
o1vm/src/interpreters/mips/column.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2948   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files         255      255           
  Lines       60855    60855           
=======================================
+ Hits        46622    46626    +4     
+ Misses      14233    14229    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrmr1993 mrmr1993 merged commit 993031f into master Jan 13, 2025
12 checks passed
@mrmr1993 mrmr1993 deleted the feature/add-parameter-to-column branch January 13, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants