Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track lookup values in interpreter and proof #2951

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

mrmr1993
Copy link
Member

This PR builds upon #2943. This propagates the values involved with lookups as witness columns for the prover.

This is a cleaned-up alternative to #2946.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 67.01031% with 32 lines in your changes missing coverage. Please review.

Project coverage is 76.61%. Comparing base (bef4b0c) to head (3ebeaf4).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/pickles/main.rs 0.00% 18 Missing ⚠️
o1vm/src/pickles/prover.rs 82.75% 5 Missing ⚠️
o1vm/src/pickles/verifier.rs 54.54% 5 Missing ⚠️
o1vm/src/pickles/column_env.rs 50.00% 3 Missing ⚠️
o1vm/src/pickles/proof.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2951      +/-   ##
==========================================
- Coverage   76.62%   76.61%   -0.02%     
==========================================
  Files         255      255              
  Lines       60923    61014      +91     
==========================================
+ Hits        46684    46747      +63     
- Misses      14239    14267      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feature/logup-tracking to master January 13, 2025 23:21
@mrmr1993 mrmr1993 merged commit 2bad3b3 into master Jan 13, 2025
11 of 12 checks passed
@mrmr1993 mrmr1993 deleted the feature/logup-values-tracking-again branch January 13, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants