-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to jQuery 2.0 #2721
Upgrade to jQuery 2.0 #2721
Conversation
Because of the upcoming History.js work, the changes to ba-bbq and hashchange can be removed from this PR. |
I can undo the changes but be aware that this will cause 2 errors in the logs on every page. I'm not sure if the errors impact any other functionality. |
Yeah, I'm only going to merge this once the History.js work is merged |
Removed the ba-bbq and ba-hashchange changes. Ready for review |
Cool, once the History.js PR is in, this is good to be merged. |
Actually, it looks like require-jquery now officially exists for jQuery 2.0 as well (https://github.com/jrburke/require-jquery/blob/master/jquery-require-sample/webapp/scripts/require-jquery.js). I think we can bring in that one, as it looks like some additional fixes have been introduced as part of that work. |
Assigning back to @BP323 for following up on the last comment. |
It looks like he didn't merge my PR but copied it because the file is identical to the one I sent in this PR. I squashed the commits to make it cleaner though. Assigning back to @nicolaasmatthijs for review. |
Looks good. Merged. |
#2720