[RHELC-1635] State action in special pkg removal report msgs #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocekm
added
the
tests/sanity
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1297 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 72 72
Lines 5178 5178
Branches 895 895
=======================================
Hits 4977 4977
Misses 119 119
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bocekm
force-pushed
the
state-action-in-special-pkgs-removal-msg
branch
from
c6fb81a to
2e5ac98
Compare
|
@pr-watson, I've reworded the messages a bit. Please take a look. EDIT: I can imagine a couple of ways to improve the messages even further - I've laid the ideas out at https://issues.redhat.com/browse/RHELC-1637. They can be worked on in another PR. |
pr-watson
approved these changes
Jul 11, 2024
bocekm
commented
Jul 11, 2024
hosekadam
reviewed
Jul 24, 2024
r0x0d
reviewed
Aug 5, 2024
Comment on lines
153
to
163
| id="SPECIAL_PACKAGES_NOT_REMOVED", | ||
| title="Special packages not removed", | ||
| description="Special packages which could not be removed", | ||
| diagnosis=message, | ||
| title="Some packages cannot be removed", |
There was a problem hiding this comment.
Maybe we should also update the id? It feels strange that in the id we call them as "special" and in the title is just "some packages"
r0x0d
reviewed
Aug 5, 2024
Customers have been confused when seeing the messages, not knowing what should they do.
bocekm
force-pushed
the
state-action-in-special-pkgs-removal-msg
branch
from
2e5ac98 to
eb5982d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers have been confused when seeing the messages, not knowing what should they do.
Jira Issues:
Checklist
[RHELC-]or[HMS-]is part of the PR titleRelease Pendingif relevant