Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #1431

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[pre-commit.ci] pre-commit autoupdate #1431

wants to merge 1 commit into from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Nov 18, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (f21f6cf) to head (736e58e).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1431   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          72       72           
  Lines        5176     5176           
  Branches      895      895           
=======================================
  Hits         4975     4975           
  Misses        119      119           
  Partials       82       82
Flag Coverage Δ
centos-linux-7 91.63% <ø> (ø)
centos-linux-8 92.49% <ø> (ø)
centos-linux-9 92.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 3c9d4c6 to c9587e4 Compare November 25, 2024 16:54
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from c9587e4 to 8dc23b2 Compare December 2, 2024 16:57
@bocekm bocekm added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run. kind/infra Related to infrastructure changes labels Dec 9, 2024
@has-bot
Copy link
Member

has-bot commented Dec 9, 2024

This PR does not require integration tests to be run.

Comment generated by an automation.

@bocekm
Copy link
Member

bocekm commented Dec 9, 2024

Before it's merged, c2r code needs to have % string formatting replaced with format() https://docs.astral.sh/ruff/rules/printf-string-formatting/.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 8dc23b2 to 060f4f6 Compare December 9, 2024 16:55
@Venefilyn
Copy link
Member

Before it's merged, c2r code needs to have % string formatting replaced with format() docs.astral.sh/ruff/rules/printf-string-formatting.

We could force merge it now and have follow-up PR?

@bocekm
Copy link
Member

bocekm commented Dec 9, 2024 •
edited
Loading

We certainly can, but creating the PR ahead of time, merging that first and then rebasing this PR seems cleaner to me as it would not create a window during which pre-commit CI fails for anyone rebasing to main.

@Venefilyn Venefilyn mentioned this pull request Dec 11, 2024
Open
@Venefilyn
Copy link
Member

We certainly can, but creating the PR ahead of time, merging that first and then rebasing this PR seems cleaner to me as it would not create a window during which pre-commit CI fails for anyone rebasing to main.

Didn't check anything but put something up at least in #1448

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
736e58e 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.3 → v0.8.3](astral-sh/ruff-pre-commit@v0.7.3...v0.8.3)
- [github.com/teemtee/tmt.git: 1.38.0 → 1.40.0](https://github.com/teemtee/tmt.git/compare/1.38.0...1.40.0)
- [github.com/jendrikseipp/vulture: v2.13 → v2.14](jendrikseipp/vulture@v2.13...v2.14)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 060f4f6 to 736e58e Compare December 16, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocekm bocekm bocekm approved these changes

@Venefilyn Venefilyn Venefilyn approved these changes

Assignees
No one assigned
Labels
kind/infra Related to infrastructure changes skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests/skip This PR does not require integration tests to be run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@has-bot @bocekm @Venefilyn