Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-967] Verify breadcrumbs source_os #1432

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Andrew-ang9
Copy link
Contributor

When you get to the end of the conversion and you go to check the system information in the migration results some of the data isn't actually filled in primarily the source_os isn't set and is still null. This PR adds in a check to see if any of the migration results are set.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • Label depicting the kind of PR it is
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@Andrew-ang9 Andrew-ang9 requested a review from a team as a code owner November 19, 2024 01:35
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5be973f). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
convert2rhel/breadcrumbs.py 35.29% 16 Missing and 6 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1432   +/-   ##
=======================================
  Coverage        ?   92.21%           
=======================================
  Files           ?       72           
  Lines           ?     5205           
  Branches        ?      902           
=======================================
  Hits            ?     4800           
  Misses          ?      307           
  Partials        ?       98           
Flag Coverage Δ
centos-linux-8 92.10% <35.29%> (?)
centos-linux-9 92.23% <35.29%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

* in the _set_activity(), _set_pkg_object(), _set_executed(),
  _set_nevra(), _set_signature() in all of these functions there is
  now some extra verification to make sure that the data that needs to
  be set is actully set
@Andrew-ang9 Andrew-ang9 marked this pull request as draft November 19, 2024 19:10
* this is a draft for the unit tests for set_activity
  set_pkg_object, set_nevra, and set_signature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant