-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #486
base: main
Are you sure you want to change the base?
Spelling #486
Conversation
...ts/BallotDrafts/sarif-v2.1.0-final-e-ballot-1/sarif-external-property-file-schema-2.1.0.json
Outdated
Show resolved
Hide resolved
Documents/BallotDrafts/sarif-v2.1.0-final-e-ballot-1/sarif-v2.1.0-final.htm
Outdated
Show resolved
Hide resolved
Documents/BallotDrafts/sarif-v2.1.0-final-e-ballot-1/sarif-v2.1.0-final.htm
Outdated
Show resolved
Hide resolved
@@ -19985,7 +19985,7 @@ <h3><a name="_Hlk7091462"></a><a name="_Toc13414331">3.38.14 taxa property</a></ | |||
|
|||
<p class=Code style='margin:0in;margin-bottom:.0001pt;background:#D9D9D9'><span | |||
style='color:black'>��������� "name": | |||
"SubstrPropogatesTaint",</span></p> | |||
"SubstrPropagatesTaint",</span></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
@@ -9,7 +9,7 @@ | |||
<div> | |||
<h3>Description</h3> | |||
|
|||
<p>The purpose of the SARIF TC is to define a standard output format for static analysis tools, which will be called the Static Analysis Results Interchange Format (SARIF). <a href="https://github.com/oasis-tcs/sarif-spec">This GitHub repository</a> supports development of the draft SARIF standard. Requests for modification should be made via <a href="https://github.com/oasis-tcs/sarif-spec/issues">Github Issues</a>.</p> | |||
<p>The purpose of the SARIF TC is to define a standard output format for static analysis tools, which will be called the Static Analysis Results Interchange Format (SARIF). <a href="https://github.com/oasis-tcs/sarif-spec">This GitHub repository</a> supports development of the draft SARIF standard. Requests for modification should be made via <a href="https://github.com/oasis-tcs/sarif-spec/issues">GitHub Issues</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a brand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert that change as that text is owned by OASIS (and not the TC) - we should separate such concerns from TC content.
@jsoref, we are finally getting around to looking at the PR, which I greatly appreciate. We will accept all corrections into a revision of SARIF 2.1 (which addresses all known errata). I will also accept all changes to our historical agenda reports, etc. I need to check into whether we can update definitive copies of things like the spec, those errors may need to remain (but will be corrected shortly in a versioned copy). |
@dmk42 @michaelcfanning I assume that this PR will not technically be merged but rather per the manual errata editing process already have been "woven" into the upcoming corrected version? |
Many items in this PR are addressed in the Approved Errata document, which is in the queue to be published any day now. There are other items that remain valid, and we should sweep them into SARIF v2.2.0. |
83e5733
to
3fa3f88
Compare
Sorry for the multiple force-pushes, I've rebased what's left of this branch. Note that this is naive rebase, it isn't applying the current version of the tooling to identify any additional errors. |
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for investing the effort.
I propose to revert all changes on approved minutes and the README.md.
We can use this PR to apply the changes to the artifacts we standaradized in version 2.1.0 though.
Given that these are only few changes and the commit history of this PR is very noisy, I suggest we create a fresh focused PR on these latter artifacts only and close this PR without action.
@@ -9,7 +9,7 @@ | |||
<div> | |||
<h3>Description</h3> | |||
|
|||
<p>The purpose of the SARIF TC is to define a standard output format for static analysis tools, which will be called the Static Analysis Results Interchange Format (SARIF). <a href="https://github.com/oasis-tcs/sarif-spec">This GitHub repository</a> supports development of the draft SARIF standard. Requests for modification should be made via <a href="https://github.com/oasis-tcs/sarif-spec/issues">Github Issues</a>.</p> | |||
<p>The purpose of the SARIF TC is to define a standard output format for static analysis tools, which will be called the Static Analysis Results Interchange Format (SARIF). <a href="https://github.com/oasis-tcs/sarif-spec">This GitHub repository</a> supports development of the draft SARIF standard. Requests for modification should be made via <a href="https://github.com/oasis-tcs/sarif-spec/issues">GitHub Issues</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert that change as that text is owned by OASIS (and not the TC) - we should separate such concerns from TC content.
@@ -38,5 +38,5 @@ | |||
<div> | |||
|
|||
<h3>Contact</h3> | |||
<p>Please send questions or comments about <a href="https://www.oasis-open.org/resources/tcadmin/github-repositories-for-oasis-tc-members-chartered-work">OASIS TC GitHub repositories</a> to <a href="mailto:robin@oasis-open.org">Robin Cover</a> and <a href="mailto:chet.ensign@oasis-open.org">Chet Ensign</a>. For questions about content in this repository, please contact the TC Chair or Co-Chairs as listed on the the SARIF TC's <a href="https://www.oasis-open.org/committees/sarif/">home page</a>.</p> | |||
<p>Please send questions or comments about <a href="https://www.oasis-open.org/resources/tcadmin/github-repositories-for-oasis-tc-members-chartered-work">OASIS TC GitHub repositories</a> to <a href="mailto:robin@oasis-open.org">Robin Cover</a> and <a href="mailto:chet.ensign@oasis-open.org">Chet Ensign</a>. For questions about content in this repository, please contact the TC Chair or Co-Chairs as listed on the SARIF TC's <a href="https://www.oasis-open.org/committees/sarif/">home page</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may also need reverting (to push upstream to OASIS)
@@ -153,7 +153,7 @@ | |||
}, | |||
|
|||
"addresses": { | |||
"description": "Addresses that will be merged with with an external run.", | |||
"description": "Addresses that will be merged with an external run.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a different PR for changes on published artifacts (on docs.oasis-open.org i.e. standards work products.
@@ -2702,7 +2702,7 @@ | |||
"properties": { | |||
|
|||
"guid": { | |||
"description": "A stable, unique identifer for the suprression in the form of a GUID.", | |||
"description": "A stable, unique identifer for the suppression in the form of a GUID.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a different PR for changes on published artifacts (on docs.oasis-open.org i.e. standards work products.
@@ -153,7 +153,7 @@ | |||
}, | |||
|
|||
"addresses": { | |||
"description": "Addresses that will be merged with with an external run.", | |||
"description": "Addresses that will be merged with an external run.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a different PR for changes on published artifacts (on docs.oasis-open.org i.e. standards work products.
@@ -105,14 +105,14 @@ None noted | |||
|
|||
## 4.4 Discuss end-to-end results management | |||
|
|||
* Mary: Presented a video from Chris Meyer demonstrating two changes to the Visual Studio SARIF Viewer targeting the interop with Github advanced security features | |||
* Mary: Presented a video from Chris Meyer demonstrating two changes to the Visual Studio SARIF Viewer targeting the interop with GitHub advanced security features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we spellcheck approved minutes?
@@ -83,7 +83,7 @@ The minutes were approved. | |||
* Charles: | |||
* Announces an SAE liaison report he will send to the TC mailing list | |||
* Esp. he suggested to rename the static in SARIF to systematic | |||
* These cricles currently discuss the possibilities that SARIF brings | |||
* These circles currently discuss the possibilities that SARIF brings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we spellcheck approved minutes?
@@ -121,7 +121,7 @@ The minutes were approved. | |||
* Jeff Williams walks everyone through the provided document [Future.md](https://github.com/oasis-tcs/sarif-spec/blob/main/Future.md) | |||
* Charles and Jeff discuss several aspects | |||
* All discuss the roadmap | |||
* Stefan suggests to move on to other aspects for this meeting and provided continued discussion in future meetins with a wider participation | |||
* Stefan suggests to move on to other aspects for this meeting and provided continued discussion in future meetings with a wider participation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we spellcheck approved minutes?
@@ -142,7 +142,7 @@ None | |||
|
|||
## 6.3 Review of Action Items (Secretary Stefan) | |||
|
|||
* There are oncoing actions from previous meetings | |||
* There are ongoing actions from previous meetings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we spellcheck approved minutes?
@@ -139,7 +139,7 @@ The minutes were approved. | |||
* Gerald: problem correlating competing approaches to grading | |||
* Stefan: this is why I think automatic rescaling may cover up different mappings from such a scale (linear maybe) to severity to another scales mapping (logarithmic?) | |||
* All: further discuss the issue | |||
* Michael: tries a summarizing proposal by e.g. shaking off security and then make the value overwritable ...? | |||
* Michael: tries a summarizing proposal by e.g. shaking off security and then make the value overridable ...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we spellcheck approved minutes?
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@78057e0#commitcomment-47652525
The action reports that the changes in this PR would make it happy: jsoref@6a36cbf
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.