Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Windows build support 2 #344

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Windows build support 2 #344

wants to merge 2 commits into from

Conversation

ZigaMr
Copy link
Contributor

@ZigaMr ZigaMr commented Jan 10, 2025 •
edited
Loading

This PR adds oasis.exe rule to Makefile.
Followup to #342

@ZigaMr ZigaMr requested a review from matevz January 10, 2025 18:24
@netlify Netlify
Copy link

netlify bot commented Jan 10, 2025 •
edited
Loading

✅ Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit f6a192c
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/6781abffd7b3c800086dba6e

matevz
matevz approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM.

Makefile
clean
windows
clean \
build-windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move up right next to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matevz matevz matevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZigaMr @matevz