Merge pull request #194 from kochen/iss_and_sub_must_be_client_id

fix: client assertion JWT iss and sub OAuth 2 client_id when requesti…
oat-sa · Nov 6, 2024 · 9fb8ee3 · 9fb8ee3
2 parents bef0d5f + fb6ac65
commit 9fb8ee3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Service/Client/LtiServiceClient.php b/src/Service/Client/LtiServiceClient.php
@@ -211,7 +211,7 @@ private function generateCredentials(RegistrationInterface $registration): strin
                     MessagePayloadInterface::HEADER_KID => $toolKeyChain->getIdentifier()
                 ],
                 [
-                    MessagePayloadInterface::CLAIM_ISS => $registration->getTool()->getAudience(),
+                    MessagePayloadInterface::CLAIM_ISS => $registration->getClientId(),
                     MessagePayloadInterface::CLAIM_SUB => $registration->getClientId(),
                     MessagePayloadInterface::CLAIM_AUD => [
                         $registration->getPlatform()->getAudience(),

diff --git a/tests/Traits/SecurityTestingTrait.php b/tests/Traits/SecurityTestingTrait.php
@@ -89,7 +89,7 @@ private function createTestClientAssertion(RegistrationInterface $registration):
                 MessagePayloadInterface::HEADER_KID => $registration->getToolKeyChain()->getIdentifier()
             ],
             [
-                MessagePayloadInterface::CLAIM_ISS => $registration->getTool()->getAudience(),
+                MessagePayloadInterface::CLAIM_ISS => $registration->getClientId(),
                 MessagePayloadInterface::CLAIM_SUB => $registration->getClientId(),
                 MessagePayloadInterface::CLAIM_AUD => [
                     $registration->getPlatform()->getAudience(),