Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

117 change the legend logic to use regex in map #118

Merged
merged 16 commits into from
Sep 7, 2024
Merged

117 change the legend logic to use regex in map #118

merged 16 commits into from
Sep 7, 2024

Conversation

obar1
Copy link
Owner

@obar1 obar1 commented Sep 7, 2024 •
edited
Loading

  • icons in yaml - not hardcoded anymore

@obar1 obar1 linked an issue Sep 7, 2024 that may be closed by this pull request
change the legend logic to use regex in map #117
Closed
1 task
@obar1 obar1 requested a review from obar1pr September 7, 2024 18:49
obar1pr
obar1pr approved these changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@obar1pr obar1pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kool stuff

obar1pr
obar1pr reviewed Sep 7, 2024
View reviewed changes
Makefile Show resolved Hide resolved
obar1pr
obar1pr reviewed Sep 7, 2024
View reviewed changes
demo.sh Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@obar1 obar1 merged commit b7514ba into main Sep 7, 2024
2 checks passed
@obar1 obar1 deleted the 117-change-the-legend-logic-to-use-regex-in-map branch September 7, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obar1pr obar1pr obar1pr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change the legend logic to use regex in map
2 participants
@obar1 @obar1pr