Feature 2795/toggle pulse report #2796
Conversation
…breakdown of responses (with emojis).
web-ui/src/pages/PulseReportPage.jsx
Outdated
| data={pieChartData} | ||
| dataKey="value" | ||
| nameKey="name" | ||
| fill={ociLightBlue} |
There was a problem hiding this comment.
@ocielliottc Could you color these the same as they are on the bar chart (color from dataInfo)?
See: line 43-45 on https://recharts.org/en-US/examples/PieChartWithCustomizedLabel
There was a problem hiding this comment.
@mkimberlin I can. Should we use shades of the blue or orange or the light blue?
There was a problem hiding this comment.
Why don't we do two charts? Blue for at work, orange for outside work. Show both if "Both" is selected in the toggle. Then it would feel like it worked similarly to the bar cart.
| {key: "externalDissatisfied", stackId: "external", color: pSBC(-.6, ociOrange), }, | ||
| {key: "externalNeutral", stackId: "external", color: pSBC(-.4, ociOrange), }, | ||
| {key: "externalSatisfied", stackId: "external", color: pSBC(-.2, ociOrange), }, | ||
| {key: "externalVerySatisfied", stackId: "external", color: ociOrange, }, |
There was a problem hiding this comment.
What do you think about going OCI color to Black?
{key: "internalVeryDissatisfied", stackId: "internal", color: pSBC(-1, ociDarkBlue), },
{key: "internalDissatisfied", stackId: "internal", color: pSBC(-.75, ociDarkBlue), },
{key: "internalNeutral", stackId: "internal", color: pSBC(-.5, ociDarkBlue), },
{key: "internalSatisfied", stackId: "internal", color: pSBC(-.25, ociDarkBlue), },
{key: "internalVerySatisfied", stackId: "internal", color: ociDarkBlue, },
{key: "externalVeryDissatisfied", stackId: "external", color: pSBC(-1, ociOrange), },
{key: "externalDissatisfied", stackId: "external", color: pSBC(-.75, ociOrange), },
{key: "externalNeutral", stackId: "external", color: pSBC(-.5, ociOrange), },
{key: "externalSatisfied", stackId: "external", color: pSBC(-.25, ociOrange), },
{key: "externalVerySatisfied", stackId: "external", color: ociOrange, },
There was a problem hiding this comment.
or maybe close to black...like -.9?
There was a problem hiding this comment.
I guess it catches your eye. The black pie slice looks out of place, to me.
There was a problem hiding this comment.
Yes. .9 is better.
There was a problem hiding this comment.
I had a hard time with the original because the gradient went in diff directions meaning the OCI color meant different things in each case. In one case it was bad, the other good. This breaks my brain less. Not sure it's more pleasing, but it's easier to understand, I think.
There was a problem hiding this comment.
No, that makes sense! That definitely crossed my mind.
There was a problem hiding this comment.
@mkimberlin Are you making that change or do you want me to?
There was a problem hiding this comment.
Sorry, got distracted. I am about to run out the door to pick up my kid, but I can push my changes and resolve the conflict after I drop her and get into the office.
…eature-2795/toggle-pulse-report
No description provided.