Skip to content

Commit

Permalink
docs: migration guide had outdated instructions (#1697)
Browse files Browse the repository at this point in the history
  • Loading branch information
johnf authored Jan 12, 2025
1 parent c4295a0 commit 2517c80
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 17 deletions.
6 changes: 4 additions & 2 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ The FontAwesome 5 and 6 fonts now take an `iconStlye` prop instead of a style na
Note: The codemod assumes you used the naming from the old README for your component e.g. FontAwesome5 etc or Icon
If you have imported the component with another name you will need to modify the codemod or make the changes yourself.

### Remove fonts from Info.plist (supported by codemod)
### Remove unused fonts from Info.plist (supported by codemod)

Fonts are now automatically loaded on iOS, so you can remove any fonts you have listed in `Info.plist`
You still need to add fonts here but should limit it to the fonts you have installed.

Check the [React Native Setup](./docs/SETUP-REACT-NATIVE.md) instructions for instructions on how update it with our included script.


### iOS
Expand Down
19 changes: 4 additions & 15 deletions docs/SETUP-REACT-NATIVE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,16 @@

> If you use Expo, please follow [this guide](./SETUP-EXPO.md) instead. This guide applies to vanilla React Native apps only.

### Android

1. Rebuild your app. No extra steps needed for Android.

### iOS

> [!TIP]
> You will need to follow these instructions any time you add a new font
1. To use the icon packages you previously installed on iOS, run:

```sh
Expand All @@ -22,25 +26,10 @@ npx rnvi-update-plist package.json ios/AppName/Info.plist
```xml
<key>UIAppFonts</key>
<array>
<string>AntDesign.ttf</string>
<string>Entypo.ttf</string>
<string>EvilIcons.ttf</string>
<string>Feather.ttf</string>
<string>FontAwesome.ttf</string>
<string>FontAwesome5_Brands.ttf</string>
<string>FontAwesome5_Regular.ttf</string>
<string>FontAwesome5_Solid.ttf</string>
<string>FontAwesome6_Brands.ttf</string>
<string>FontAwesome6_Regular.ttf</string>
<string>FontAwesome6_Solid.ttf</string>
<string>Fontisto.ttf</string>
<string>Foundation.ttf</string>
<string>Ionicons.ttf</string>
<string>MaterialDesignIcons.ttf</string>
<string>MaterialIcons.ttf</string>
<string>Octicons.ttf</string>
<string>SimpleLineIcons.ttf</string>
<string>Zocial.ttf</string>
</array>
```
</details>
Expand Down

0 comments on commit 2517c80

Please sign in to comment.