-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add L4 IT #233
Open
shawntanzk
wants to merge
7
commits into
master
Choose a base branch
from
L4-IT
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add L4 IT #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #226 Note given the rest of IT aren't species restricted, I opted to make this species agnostic too
shawntanzk
commented
Feb 16, 2022
src/ontology/bdso-edit.owl
Outdated
SubClassOf(<http://purl.obolibrary.org/obo/CL_4023119> <http://purl.obolibrary.org/obo/PCL_1000002>) | ||
SubClassOf(<http://purl.obolibrary.org/obo/CL_4023119> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0000053> <http://purl.obolibrary.org/obo/PATO_0070002>)) | ||
AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "PMID:33184512") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/PCL_1000000> "An intratelencephalic-projecting glutamatergic neuron that is located in the boundary between L2/3 and L5 of the primary motor cortex. These cells have diverse morphologies with some pyramidal and some stellate cells.") | ||
AnnotationAssertion(dce:creator <http://purl.obolibrary.org/obo/PCL_1000000> <http://orcid.org/0000-0001-7258-9596>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be dc:contributor
shawntanzk
commented
Feb 16, 2022
src/ontology/bdso-edit.owl
Outdated
AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "PMID:33184512") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/PCL_1000000> "An intratelencephalic-projecting glutamatergic neuron that is located in the boundary between L2/3 and L5 of the primary motor cortex. These cells have diverse morphologies with some pyramidal and some stellate cells.") | ||
AnnotationAssertion(dce:creator <http://purl.obolibrary.org/obo/PCL_1000000> <http://orcid.org/0000-0001-7258-9596>) | ||
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> <http://purl.obolibrary.org/obo/PCL_1000000> "ILX:0770172") | ||
AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "PMID:25525751") rdfs:comment <http://purl.obolibrary.org/obo/PCL_1000000> "These cells likely corresponded to the quasi-L4 neurons described previously in the motor cortex.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain l4 issue here
shawntanzk
commented
Feb 16, 2022
src/ontology/bdso-edit.owl
Outdated
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> <http://purl.obolibrary.org/obo/PCL_1000000> "ILX:0770172") | ||
AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "PMID:25525751") rdfs:comment <http://purl.obolibrary.org/obo/PCL_1000000> "These cells likely corresponded to the quasi-L4 neurons described previously in the motor cortex.") | ||
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/PCL_1000000> "L4 intratelencephalic projecting glutamatergic neuron of the primary motor cortex") | ||
EquivalentClasses(<http://purl.obolibrary.org/obo/PCL_1000000> ObjectIntersectionOf(<http://purl.obolibrary.org/obo/CL_4023040> ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0002100> <http://purl.obolibrary.org/obo/UBERON_0001384>) ObjectSomeValuesFrom(<http://purl.obolibrary.org/obo/RO_0002100> <http://purl.obolibrary.org/obo/UBERON_0005393>))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
equiv class is wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226
Note given the rest of IT aren't species restricted, I opted to make this species agnostic too