-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nan warning in get_bitinformation; Closes #200 #260
base: main
Are you sure you want to change the base?
Conversation
I apologize, my organization is swapping SSL certs and that seems to be preventing me from running the unit test, but this PR is straightforward. |
Thanks for the PR. First time contributors cannot run the tests automatically. We allow those manually. So no issue on your side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also add a line to CHANGELOG.md? Thanks!
Ideally although NaN's are not automatically converted to a mask at the moment, but that could easily be added. Well maybe requires some work to avoid a double pass of the data, but yes. |
Changelog updated. |
Well, this is awkward. |
Eh, I don't particularly like my solution, which just loosens the unit test to permit the multiple warnings. The alternative is to import some other module that let's us inspect the calling function to decide whether or not to throw the warning. Let me know if you'd prefer that. |
Oh, that is unfortunate. Let me fix this in #261. |
Co-authored-by: Hauke Schulz <43613877+observingClouds@users.noreply.github.com>
ddd5d26
to
897fc03
Compare
Let's start by closing the issue on warnings, but I think the implementations could be rewritten to handle NaN's, which would be good for masked datasets.