fix: Enable 'High priority' to be selected easily in Auto Suggest (#1996

) Fixes #1943 The order of priorities in auto suggestion is now - high - medium - low - highest - lowest This retains the original order, for people's muscle memory. And it means that the longer names are after the shorter ones, which also makes it possible to type both, and it means that typing parts of names selects the same result as before highest and lowest were added.
obsidian-tasks-group · May 30, 2023 · d63f228 · d63f228
1 parent 47b565c
commit d63f228
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/docs/Getting Started/Auto-Suggest.md b/docs/Getting Started/Auto-Suggest.md
@@ -174,10 +174,10 @@ Similarly, you can type some fraction of the word `start` (of whatever length is
 | Searchable Text               | Text that is added         |
 | ----------------------------- | -------------------------- |
 | ⏎                             | \<new line>                |
-| 🔺 highest priority           | 🔺                         |
 | ⏫ high priority              | ⏫                         |
 | 🔼 medium priority            | 🔼                         |
 | 🔽 low priority               | 🔽                         |
+| 🔺 highest priority           | 🔺                         |
 | ⏬️ lowest priority            | ⏬️                         |
 | 🔁 recurring (repeat)         | 🔁                         |
 | every                         | 🔁 every                   |

diff --git a/src/Suggestor/Suggestor.ts b/src/Suggestor/Suggestor.ts
@@ -83,10 +83,6 @@ function addTaskPropertySuggestions(
             appendText: `${symbols.scheduledDateSymbol} `,
         });
     if (!hasPriority(line)) {
-        genericSuggestions.push({
-            displayText: `${symbols.prioritySymbols.Highest} highest priority`,
-            appendText: `${symbols.prioritySymbols.Highest} `,
-        });
         genericSuggestions.push({
             displayText: `${symbols.prioritySymbols.High} high priority`,
             appendText: `${symbols.prioritySymbols.High} `,
@@ -99,6 +95,10 @@ function addTaskPropertySuggestions(
             displayText: `${symbols.prioritySymbols.Low} low priority`,
             appendText: `${symbols.prioritySymbols.Low} `,
         });
+        genericSuggestions.push({
+            displayText: `${symbols.prioritySymbols.Highest} highest priority`,
+            appendText: `${symbols.prioritySymbols.Highest} `,
+        });
         genericSuggestions.push({
             displayText: `${symbols.prioritySymbols.Lowest} lowest priority`,
             appendText: `${symbols.prioritySymbols.Lowest} `,

diff --git a/....test.auto-complete_with__dataview__symbols_show_all_suggested_text.approved.md b/....test.auto-complete_with__dataview__symbols_show_all_suggested_text.approved.md
@@ -4,10 +4,10 @@
 | due:: due date | due::  |
 | start:: start date | start::  |
 | scheduled:: scheduled date | scheduled::  |
-| priority:: highest highest priority | priority:: highest  |
 | priority:: high high priority | priority:: high  |
 | priority:: medium medium priority | priority:: medium  |
 | priority:: low low priority | priority:: low  |
+| priority:: highest highest priority | priority:: highest  |
 | priority:: lowest lowest priority | priority:: lowest  |
 | repeat:: recurring (repeat) | repeat::  |
 | created:: created today (2022-07-11) | created:: 2022-07-11  |

diff --git a/...tor.test.auto-complete_with__emoji__symbols_show_all_suggested_text.approved.md b/...tor.test.auto-complete_with__emoji__symbols_show_all_suggested_text.approved.md
@@ -4,10 +4,10 @@
 | 📅 due date | 📅  |
 | 🛫 start date | 🛫  |
 | ⏳ scheduled date | ⏳  |
-| 🔺 highest priority | 🔺  |
 | ⏫ high priority | ⏫  |
 | 🔼 medium priority | 🔼  |
 | 🔽 low priority | 🔽  |
+| 🔺 highest priority | 🔺  |
 | ⏬ lowest priority | ⏬  |
 | 🔁 recurring (repeat) | 🔁  |
 | ➕ created today (2022-07-11) | ➕ 2022-07-11  |

diff --git a/tests/Suggestor/Suggestor.test.ts b/tests/Suggestor/Suggestor.test.ts
@@ -48,8 +48,8 @@ describe.each([
             { displayText: `${dueDateSymbol} due date`, appendText: `${dueDateSymbol} ` },
             { displayText: `${startDateSymbol} start date`, appendText: `${startDateSymbol} ` },
             { displayText: `${scheduledDateSymbol} scheduled date`, appendText: `${scheduledDateSymbol} ` },
-            { displayText: `${prioritySymbols.Highest} highest priority`, appendText: `${prioritySymbols.Highest} ` },
             { displayText: `${prioritySymbols.High} high priority`, appendText: `${prioritySymbols.High} ` },
+            { displayText: `${prioritySymbols.Medium} medium priority`, appendText: `${prioritySymbols.Medium} ` },
         ]);
     });