Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for move_rel and move_abs not working on Linux #51

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

positiveway
Copy link
Contributor

fix for issue #50

@positiveway
Copy link
Contributor Author

positiveway commented Jan 13, 2022

@obv-mikhail can you please review this? I would like to contribute to this library by submitting fixes and features via PRs rather than making my own fork.

I have other PRs planning:

  • Issue In Linux implementation some keys have the same codes as Numpad keys #52
  • Implementing common Trait for KeybdKey and MouseButton. Quite useful in my case. I am mapping controller keys to keyboard and mouse ones. So storing layout (pairs) in HashMap seems like a logical option. Currently, mouse keys and keyboard keys can't be stored together although they provide the same methods. This one I already implemented locally.
  • Currently bind_all overwrites previous bindings for specific keys. It would make sense to only use a common handler for keys that currently have no handler at all. Proper implementation of this unction would be adding a parameter rebind. If true all previous binding would be cleared.
    • Or an even better way - chained callbacks. First calling the common handler and then a specific handler for a key. Need to look into this more. Idea was already proposed in Support binding a key multiple times #10

It would be more convenient to submit PRs in subsequent order after a previous one has already been approved.

Copy link
Owner

@obv-mikhail obv-mikhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@positiveway looks good. Thanks for the PR.

@obv-mikhail obv-mikhail merged commit c8ce830 into obv-mikhail:develop Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants