Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releasing a student doesn't unshare custom levels #2315

Closed
faucomte97 opened this issue Jun 6, 2024 · 4 comments · Fixed by ocadotechnology/codeforlife-workspace#150 or #2376
Closed

Releasing a student doesn't unshare custom levels #2315

faucomte97 opened this issue Jun 6, 2024 · 4 comments · Fixed by ocadotechnology/codeforlife-workspace#150 or #2376
Assignees
@sebp999
Labels
bug volunteers

Comments

@faucomte97
Copy link
Contributor

faucomte97 commented Jun 6, 2024 •
edited
Loading

Describe the bug
If a student who has created a custom levels is released by a teacher, their custom level remains shared with the teacher. Since the student no longer belongs to the school, this causes the teacher to see the error page instead of the levels page.

To Reproduce
Steps to reproduce the behaviour:

  1. Prerequisites: Have a teacher account with a student who has created a custom level. Confirm the teacher can see the level in the shared levels.
  2. Release the student.
  3. Go back to the levels page.
  4. Notice that the page fails to load.

Expected behaviour
When a student is released, it should also "unshare" all of their custom levels, as their are no longer in the school.
@faucomte97 faucomte97 linked a pull request Oct 8, 2024 that will close this issue
fix: teacher dashboard don't show levels for independent stu… ocadotechnology/rapid-router#1739
Closed
3 tasks
@faucomte97 faucomte97 linked a pull request Oct 16, 2024 that will close this issue
user.email ocadotechnology/codeforlife-workspace#150
Merged
@sebp999 sebp999 mentioned this issue Oct 31, 2024
Merged
@faucomte97 faucomte97 reopened this Nov 1, 2024
@faucomte97 faucomte97 reopened this Nov 2, 2024
@faucomte97
Copy link
Contributor Author

LGTM

1 similar comment
@lauracumming
Copy link

LGTM

@lauracumming
Copy link

LGTM (PROD)

@faucomte97
Copy link
Contributor Author

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebp999 sebp999

Labels
bug volunteers
Projects
None yet
Milestone
No milestone
3 participants
@sebp999 @faucomte97 @lauracumming