Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: teacher dashboard don't show levels for independent stu… #1739

Conversation

sebp999
Copy link
Contributor

@sebp999 sebp999 commented Oct 4, 2024

…dents

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

@sebp999 sebp999 changed the title 2315 bugfix: teacher dashboard don't show levels for independent stu… 2315 fix: teacher dashboard don't show levels for independent stu… Oct 4, 2024
@sebp999 sebp999 changed the title 2315 fix: teacher dashboard don't show levels for independent stu… fix: teacher dashboard don't show levels for independent stu… Oct 4, 2024
@faucomte97
Copy link
Contributor

Hey @sebp999, since your last contribution we've made some changes, we now have an extra check which ensures contributors have signed our contributor agreement.

You can find the agreement and the instructions on how to sign it here: https://github.com/ocadotechnology/codeforlife-workspace/blob/main/CONTRIBUTING.md#become-a-contributor

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sebp999)


game/views/level_selection.py line 197 at r1 (raw file):

                    )
                else:
                    if not level.owner.student.is_independent():

I think it would be better to fix the issue at the time that the student is released from the school rather than when the shared levels are being collected.

As in, when a teacher releases a student from a school and "turns them" into an independent student, that code should also find all of that student's custom levels, and for each level, remove all users from the list of "shared with" users, since independent student cannot share levels with anyone as of now.

The logic for releasing a student is within the portal repository however, so you'd have to look there

@faucomte97
Copy link
Contributor

Closing as addressed by ocadotechnology/codeforlife-portal#2376 instead.

@faucomte97 faucomte97 closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releasing a student doesn't unshare custom levels
2 participants