Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compile cow block properly #1524

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix: Compile cow block properly #1524

merged 1 commit into from
Nov 17, 2023

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Nov 16, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1524 (c5081cb) into master (e59bc5d) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
+ Coverage   91.69%   91.74%   +0.04%     
==========================================
  Files         110      110              
  Lines        5864     5860       -4     
==========================================
- Hits         5377     5376       -1     
+ Misses        487      484       -3     
Files Coverage Δ
game/end_to_end_tests/test_play_through.py 100.00% <ø> (+1.06%) ⬆️

... and 2 files with indirect coverage changes

@faucomte97 faucomte97 enabled auto-merge (squash) November 16, 2023 19:14
Copy link
Contributor

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 902d65e into master Nov 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants