Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1573-Fix Saving Feature #1574

Merged

Conversation

AbdelrahmanDeghedy
Copy link
Contributor

@AbdelrahmanDeghedy AbdelrahmanDeghedy commented Jan 22, 2024

Description

  • This is a fix to this issue.
  • It was done by adding the missing request parameter pythonViewEnabled to the API call for saving the workspace.
  • An extra validation step was added to validate the request parameters sent to the save_workspace function, so if it happened again, it would be caught easily in the Python logs.

How Has This Been Tested?

Screencast.from.22-01-24.15.41.20.webm

New error message, if this to happen again

Screenshot from 2024-01-22 15-48-12


This change is Reviewable

@AbdelrahmanDeghedy AbdelrahmanDeghedy self-assigned this Jan 22, 2024
Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AbdelrahmanDeghedy)


game/views/level.py line 368 at r1 (raw file):

    if missing_params != []:
        raise Exception("Request missing the following required parameters", missing_params)
    

Just some extra whitespaces here, please remove

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AbdelrahmanDeghedy)

@faucomte97 faucomte97 merged commit f95f2e2 into ocadotechnology:master Jan 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants