Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on OCaml 4 #13

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Build on OCaml 4 #13

merged 1 commit into from
Aug 20, 2023

Conversation

polytypic
Copy link
Collaborator

@polytypic polytypic commented Aug 19, 2023

The Par_incr library doesn't actually depend on OCaml 5+ only features. This PR enables Par_incr to be built and used on OCaml 4.14+.

  • OCaml 4.12.0 added the Atomic module.
  • OCaml 4.14.0 added the Out_channel module.

It would be possible to port to earlier 4.x versions by avoiding some of the Stdlib features or by using shims.

@polytypic polytypic changed the title Port to OCaml 4 WIP: Port to OCaml 4 Aug 19, 2023
@polytypic polytypic force-pushed the port-to-ocaml-4 branch 8 times, most recently from e300d61 to 35a7b84 Compare August 19, 2023 16:50
@polytypic polytypic changed the title WIP: Port to OCaml 4 Port to OCaml 4 Aug 19, 2023
@polytypic polytypic force-pushed the port-to-ocaml-4 branch 4 times, most recently from 33b185b to 27c5dd7 Compare August 19, 2023 17:19
@polytypic polytypic changed the title Port to OCaml 4 Build on OCaml 4 Aug 19, 2023
@polytypic polytypic marked this pull request as ready for review August 19, 2023 20:13
@dipeshkaphle dipeshkaphle merged commit 993dad7 into main Aug 20, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants