Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: provide sortText in completion items #925

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

Khady
Copy link
Contributor

@Khady Khady commented Feb 26, 2019

This PR adds fills the sortText field of completion items in textDocument/completion response. This is necessary to make sure that the client will respect the order decided by merlin.

Tested on emacs only.

https://microsoft.github.io/language-server-protocol/specification#textDocument_completion
tigersoldier/company-lsp#56 (comment)

Per specification, the server can specify sortText for each candidate. Candidates should be sorted by sortText if the server populates them, or sorted by the labels if sortText is not populated.

@andreypopp
Copy link
Member

Thanks!

@andreypopp andreypopp merged commit 40c9840 into ocaml:master Feb 26, 2019
@Khady Khady deleted the lsp-sort-completion branch March 1, 2019 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants